Do not parallelize definition building if it gives no advantage #10776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the cases when there are 1 or 2 cores the fork join pool is of size 1 and therefore does not achieve parallelized execution. For this case we can load definitions on the main thread.
graemerocher
approved these changes
Apr 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the cases with 1 or 2 cores the fork join pool is of size 1 and therefore does not achieve parallelized execution. For this case, we can load definitions on the main thread.
This did not produce significant performance improvements on my machine when I set
-XX:ActiveProcessorCount=1JVM option, so the overhead of using the pool is probably minimal. But this will get rid of the case when the main thread is on the same thread as the fork-join pool worker and is waiting for it, which I could not test on my machine.