Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to access SSL session #10792

Merged
merged 1 commit into from
May 6, 2024
Merged

Add API to access SSL session #10792

merged 1 commit into from
May 6, 2024

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented May 3, 2024

This is useful for e.g. the session ID.

Because I replaced the getCertificate implementation with this, this is already covered by tests.

This is useful for e.g. the session ID.

Because I replaced the getCertificate implementation with this, this is already covered by tests.
@yawkat yawkat added the type: improvement A minor improvement to an existing feature label May 3, 2024
@yawkat yawkat added this to the 4.5.0 milestone May 3, 2024
@yawkat yawkat requested review from timyates and graemerocher May 3, 2024 06:18
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
63.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@yawkat yawkat merged commit 905467b into 4.5.x May 6, 2024
16 of 17 checks passed
@yawkat yawkat deleted the ssl-session branch May 6, 2024 06:39
sdelamo pushed a commit that referenced this pull request May 9, 2024
This is useful for e.g. the session ID.

Because I replaced the getCertificate implementation with this, this is already covered by tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants