fix: Build with GRPC KSP processing fails #10811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirroring the guard we have in AbstractJavaElement https://github.com/micronaut-projects/micronaut-core/blob/02445227ee73ba3b2fc8d7fca6f3aad23a4c5362/inject-java/src/main/java/io/micronaut/annotation/processing/visitor/AbstractJavaElement.java#L363
timyates
added
type: bug
graemerocher
approved these changes
May 9, 2024
|
sdelamo
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They bytecode for GeneratedMessageV3 from protobuf-java caused our Ksp processor to choke
Here I have reproduced the issue (for kotlin) with the same in java to show it working
We have a guard in AbstractJavaElement which was missing from the Ksp equivalent and caused us to fall off the end of a list (when indexed by a separate list)
Fixes #10647