Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct clients getting shutdown by request scope #10890

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Correct clients getting shutdown by request scope #10890

merged 2 commits into from
Jun 7, 2024

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Jun 6, 2024 •
edited
Loading

@graemerocher graemerocher requested a review from yawkat June 6, 2024 16:07
@graemerocher graemerocher added the type: bug Something isn't working label Jun 6, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@graemerocher graemerocher merged commit 2185249 into 4.5.x Jun 7, 2024
17 checks passed
@graemerocher graemerocher deleted the request-scope-clients branch June 7, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@RequestScope cannot be used with HTTP client blocking requests
2 participants
@graemerocher @yawkat