Can't find micronautserviceconfigs when running as jlink-ed application #10982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
graemerocher
added
the
type: improvement
|
You can write the test in JUnit 5 / java if it is easier for you |
|
could you sign the CLA? Thanks. |
rfscholte
commented
Jul 17, 2024
| @@ -187,6 +189,20 @@ private void findMicronautMetaServiceConfigs(BiConsumer<URI, String> consumer) t | |||
| uniqueURIs.add(uri); | |||
| } | |||
|
|
|||
| if(uniqueURIs.isEmpty()) { | |||
There was a problem hiding this comment.
Not 100% sure if this emtpy-check is correct. For JLink it is, which was the usecase. In case of combining classpath and modulepath this might need to be revisited, although I wonder if people would do that.
graemerocher
approved these changes
Jul 19, 2024
graemerocher
requested changes
Jul 22, 2024
|
//cc @rfscholte |
|
that's absolutely possible. Currently enjoying JCrete, while this code is still at home. I'll come back on this next week. |
|
thank you! |
|
unfortunately seems to break native image support. Let me investigate what can be done |
graemerocher
approved these changes
Aug 6, 2024
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These few lines of code should be the base of the fix. And it actually doesn't require a predefined set. Tests are still missing as I'm struggling with the spock support in my IDE.
This fixes #10842