Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enums as each property keys. Fixes #10944 #10993

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix enums as each property keys. Fixes #10944 #10993

merged 2 commits into from
Jul 19, 2024

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Jul 18, 2024 •
edited
Loading

Convert name to enum if possible. Fixes #10944

@graemerocher graemerocher added the type: bug Something isn't working label Jul 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@graemerocher graemerocher merged commit 22aab3d into 4.5.x Jul 19, 2024
17 checks passed
@graemerocher graemerocher deleted the issue10944 branch July 19, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
4.5.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graemerocher @dstepanov