Http server: Allow to disable not-found on missing body #11059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
requested changes
Aug 7, 2024
core-reactive/src/main/java/io/micronaut/core/async/publisher/Publishers.java
Outdated
Show resolved
Hide resolved
http-server/src/main/java/io/micronaut/http/server/HttpServerConfiguration.java
Outdated
Show resolved
Hide resolved
...k-netty/src/test/java/io/micronaut/http/server/tck/netty/tests/NettyHttpServerTestSuite.java
Outdated
Show resolved
Hide resolved
sdelamo
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Please, add a mention in https://github.com/micronaut-projects/micronaut-core/blob/4.6.x/src/main/docs/guide/httpServer/serverIO.adoc#404-responses to tell users how to disable this behaviour and what would be the behaviour if they set an not-found-on-missing-bodytofalse`
yawkat
reviewed
Aug 8, 2024
http-server/src/main/java/io/micronaut/http/server/RouteExecutor.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Aug 8, 2024
| @@ -678,8 +687,7 @@ private CorePublisher<MutableHttpResponse<?>> fromReactiveExecute(PropagatedCont | |||
| } | |||
| return response.contextWrite(context -> ReactorPropagation.addPropagatedContext(context, propagatedContext).put(ServerRequestContext.KEY, request)); | |||
| } | |||
| MutableHttpResponse<?> response = forStatus(routeInfo, null).body(body); | |||
| return processPublisherBody(propagatedContext, request, response, routeInfo); | |||
| return processPublisherBody(propagatedContext, request, forStatus(routeInfo, null), false, publisher, routeInfo); | |||
There was a problem hiding this comment.
I did a bit of refactoring to pass the converted publisher right away
yawkat
approved these changes
Aug 8, 2024
…or.java Co-authored-by: Jonas Konrad <jonas.konrad@oracle.com>
|
Added docs @sdelamo |
graemerocher
approved these changes
Aug 9, 2024
sdelamo
approved these changes
Aug 12, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.