Fix issue with root routing + improve tests #11123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should there be an HTTP TCK test for the root mapping thing? |
|
Added |
graemerocher
approved these changes
Aug 27, 2024
yawkat
reviewed
Aug 28, 2024
| @@ -68,7 +68,7 @@ private UriTemplateMatcher(String templateString, List<UriTemplateParser.Part> p | |||
| this.parts = parts; | |||
| List<UriMatchVariable> variables = new ArrayList<>(); | |||
| this.segments = provideMatchSegments(parts, variables); | |||
| this.isRoot = segments.length == 0 || segments[0].type == SegmentType.LITERAL && isRoot(segments[0].value); | |||
| this.isRoot = segments.length == 0 || segments.length == 1 && segments[0].type == SegmentType.LITERAL && isRoot(segments[0].value); | |||
There was a problem hiding this comment.
Suggested change
| this.isRoot = segments.length == 0 || segments.length == 1 && segments[0].type == SegmentType.LITERAL && isRoot(segments[0].value); | |
| this.isRoot = segments.length == 0 || (segments.length == 1 && segments[0].type == SegmentType.LITERAL && isRoot(segments[0].value)); |
yawkat
approved these changes
Aug 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11122
Included
@Requires(propertyto all the controllers in Netty Server tests to make debugging easier, added a test to fail if somebody adds a not-property-hidden controller.