fix combination of lombok.Builder with Introspected without builder #11347
Conversation
| @@ -722,7 +722,8 @@ private void writeIntrospectionClass(ClassWriterOutputVisitor classWriterOutputV | |||
| dispatchWriter.buildGetTargetMethodByIndex(classWriter); | |||
| buildFindIndexedProperty(classWriter); | |||
| buildGetIndexedProperties(classWriter); | |||
| boolean hasBuilder = annotationMetadata != null && annotationMetadata.isPresent(Introspected.class, "builder"); | |||
| boolean hasBuilder = annotationMetadata != null && | |||
| (annotationMetadata.isPresent(Introspected.class, "builder") || annotationMetadata.hasDeclaredAnnotation("lombok.Builder")); | |||
There was a problem hiding this comment.
Can you add an annotation remapper to avoid referencing the Lombok here?
There was a problem hiding this comment.
but also are we sure we want to generate an instrospection for all Lombok annotated builders?
There was a problem hiding this comment.
Then we can add a visitor that will only remap it if the builder annotation is present
There was a problem hiding this comment.
so I move the reference to Lombok from one place to another?
| // unfortunately sometimes we don't see the Lombok transformations | ||
| // so assume if the class is annotated with Lombok builder we cannot | ||
| // access the constructor. | ||
| if (!ce.hasDeclaredAnnotation(ANN_LOMBOK_BUILDER)) { |
There was a problem hiding this comment.
Can this be added as an option to the introspected or builder annotation and use a remapper to avoid the lombok reference?
There was a problem hiding this comment.
not sure I understand how
| .orElse(null); | ||
| if (methodElement == null) { | ||
| // Lombok processing not done yet, try again in the next round. | ||
| throw new ElementPostponedToNextRoundException(element); |
There was a problem hiding this comment.
Maybe we should deprecate PostponedToNextRoundException and use only ElementPostponedToNextRoundException
|
Currently users have to manually defined
@Introspected(builder=..)when using Lombok. This change adds native processing of Lombok builder. Not a huge fan of the direct references to Lombok annotation names but I don't see many other options.Fixes #11344