Regression Writable in Filter #9287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test which reproduces the way the Micronaut Views Filter writes a writable as the body in the response within a filter.
sdelamo
added
type: bug
|
This test passes in Micronaut Framework 3 but it fails currently in 4. @yawkat @graemerocher can you help with this? This is currently breaks the views module. |
|
this one is caused because the type of the response is not statically known (controller has different body type than filter). handler matching is invariant so it cant find the proper handler. i will fix it by making WritableBodyWriter a raw message handler, which has covariant matching, but it's ugly |
graemerocher
approved these changes
May 22, 2023
This was referenced Oct 18, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test which reproduces the way the Micronaut Views Filter writes a writable as the body in the response within a filter.