Fix out-of-order write in HttpStreamsHandler #9416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in retrospect can you target 3.9.x the new will manually back port to avoid the build issues |
HttpStreamsHandler delays writing the first HttpContent to when the request has been fully written. The second HttpContent was not delayed however, so when writing the request took time (apparently with TLS?), the second HttpContent was written before the first. This patch delays all further writes (normal, complete and error) until the first content has been written. Should fix micronaut-projects/micronaut-tracing#316
|
SonarCloud Quality Gate failed. |
timyates
approved these changes
Jun 8, 2023
|
now we need a back port PR to 3.8.x that also fixes the build |
|
@graemerocher the streams-order branch is still based on 3.8, so it can pr fine to 3.8.x. but i dont know how to fix the build. |
|
it is a matter of upgrading to the latest patch releases of the build plugins used by that branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpStreamsHandler delays writing the first HttpContent to when the request has been fully written. The second HttpContent was not delayed however, so when writing the request took time (apparently with TLS?), the second HttpContent was written before the first.
This patch delays all further writes (normal, complete and error) until the first content has been written.
Should fix micronaut-projects/micronaut-tracing#316