Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove webdriver-binaries-gradle-plugin #9490

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jun 23, 2023

The webdriver binary plugin was useful to ease running the Web tests with real browser but we can get rid of it.

It currently fails with:

> Failed to apply plugin class 'io.micronaut.build.docs.JavadocAggregatorPlugin'.
   > A problem occurred configuring project ':test-suite'.
      > Could not resolve all files for configuration ':test-suite:classpath'.
         > Could not find org.ysb33r.gradle:grolifant:0.5.1.
           Searched in the following locations:
             - https://plugins.gradle.org/m2/org/ysb33r/gradle/grolifant/0.5.1/grolifant-0.5.1.pom
             - https://repo.maven.apache.org/maven2/org/ysb33r/gradle/grolifant/0.5.1/grolifant-0.5.1.pom
           Required by:
               project :test-suite > gradle.plugin.com.energizedwork.webdriver-binaries:webdriver-binaries-gradle-plugin:1.4

It currently fails with:

```
> Failed to apply plugin class 'io.micronaut.build.docs.JavadocAggregatorPlugin'.
   > A problem occurred configuring project ':test-suite'.
      > Could not resolve all files for configuration ':test-suite:classpath'.
         > Could not find org.ysb33r.gradle:grolifant:0.5.1.
           Searched in the following locations:
             - https://plugins.gradle.org/m2/org/ysb33r/gradle/grolifant/0.5.1/grolifant-0.5.1.pom
             - https://repo.maven.apache.org/maven2/org/ysb33r/gradle/grolifant/0.5.1/grolifant-0.5.1.pom
           Required by:
               project :test-suite > gradle.plugin.com.energizedwork.webdriver-binaries:webdriver-binaries-gradle-plugin:1.4
``
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo requested review from melix and timyates June 23, 2023 14:54
@sdelamo sdelamo merged commit a8bca41 into 3.9.x Jun 23, 2023
10 checks passed
@sdelamo sdelamo deleted the remove-webinaries-driver-plugin branch June 23, 2023 15:02
@timyates
Copy link
Contributor

@sdelamo 🤔 Too slow...

I think we can also do this:

 diff --git a/gradle.properties b/gradle.properties
index c95db2edab..4ba8322725 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -44,9 +44,6 @@ kapt.use.worker.api=true

 # Dependency Versions
 micronautMavenPluginVersion=3.5.4
-chromedriverVersion=79.0.3945.36
-geckodriverVersion=0.26.0
-webdriverBinariesVersion=1.4
 kotlinVersion=1.6.10
 kotlin.stdlib.default.dependency=false

diff --git a/gradle/geb.gradle b/gradle/geb.gradle
index f82b46a5b9..7442be7808 100644
--- a/gradle/geb.gradle
+++ b/gradle/geb.gradle
@@ -11,6 +11,4 @@ dependencies {

 tasks.named("test") {
     systemProperty "geb.env", System.getProperty('geb.env')
-    systemProperty "webdriver.chrome.driver", System.getProperty('webdriver.chrome.driver')
-    systemProperty "webdriver.gecko.driver", System.getProperty('webdriver.gecko.driver')
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants