-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 9905 websphere deploy war #9906
Conversation
I have checked on my local machine/docker configuration that the provided patch fixes a Micronaut app as well as a Grails 5.x application. If you want to try this yourself, let me know and I can provide instructions on running WebSphere in Docker. |
provide instructions please |
core/src/main/java/io/micronaut/core/io/service/ServiceScanner.java
Outdated
Show resolved
Hide resolved
inject/src/main/java/io/micronaut/context/DefaultBeanContext.java
Outdated
Show resolved
Hide resolved
Attached instructions were sent to me and worked for me, with a couple of adjustments annotated. Some of the docker commands I have here (easier to copy/paste from here, perhaps, than from the pdf)
|
This reverts commit 4846e62.
As a point of info, 3.8.x is needed to support Grails 5.3.x, but these changes should be merged forward as well. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs 73.3% Coverage The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
* Workaround quirks with WebSphere classloader * Remove nulls from collected bean definition refs * Fix issue link * Revert "Remove nulls from collected bean definition refs" This reverts commit 4846e62.
Fixes #9905