Support @IdClass and multiple @Id
#2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radovanradic
reviewed
Apr 9, 2024
| */ | ||
| @NonNull | ||
| default List<PersistentProperty> getIdentityProperties() { | ||
| if (getIdentity() != null) { |
There was a problem hiding this comment.
Should look at getCompositeIdentity() ?
There was a problem hiding this comment.
I will try to add it an see if it's going to work
There was a problem hiding this comment.
I guess check if getCompositeIdentity is not empty then return it, else list with getIdentity or else empty list
To have same logic as implementing classes I guess.
radovanradic
reviewed
Apr 9, 2024
data-model/src/main/java/io/micronaut/data/model/runtime/RuntimePersistentEntity.java
Show resolved
Hide resolved
radovanradic
reviewed
Apr 9, 2024
| @@ -0,0 +1,24 @@ | |||
| /* | |||
| * Copyright 2017-2020 original authors | |||
There was a problem hiding this comment.
Not really important, but maybe we should just remove copyright from test classes? If not then update from 2020 to the current year.
There was a problem hiding this comment.
Probably, I just copied :/
|
radovanradic
approved these changes
Apr 9, 2024
dstepanov
added a commit
that referenced
this pull request
Apr 15, 2024
This reverts commit 3ac9d2d.
dstepanov
added a commit
that referenced
this pull request
Apr 17, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.