fix(deps): update dependency io.micronaut:micronaut-core-bom to v4.5.1 #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/micronaut
branch
from
abb475e to
756f518
Compare
renovate
bot
changed the title
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/micronaut
branch
from
756f518 to
a4dafb8
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/micronaut
branch
2 times, most recently
from
c1964fb to
4060180
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/micronaut
branch
from
4060180 to
3ac5910
Compare
renovate
bot
changed the title
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/micronaut
branch
from
3ac5910 to
73c4ef8
Compare
renovate
bot
force-pushed
the
renovate/micronaut
branch
from
73c4ef8 to
c9b7e30
Compare
renovate
bot
changed the title
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/micronaut
branch
from
c9b7e30 to
07e2413
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/micronaut
branch
from
07e2413 to
763cc64
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
I have a fix once micronaut-projects/micronaut-servlet#731 is released |
graemerocher
requested changes
Jun 5, 2024
| final GoogleFunctionHttpRequest<Object> req = | ||
| new GoogleFunctionHttpRequest<>(request, res, conversionService, applicationContext.getBean(BodyBuilder.class)); | ||
| new GoogleFunctionHttpRequest<>(request, res, conversionService, applicationContext.getBean(BodyBuilder.class), applicationContext.getBean(Executor.class, Qualifiers.byName(TaskExecutors.BLOCKING))); |
There was a problem hiding this comment.
this bean lookup will run on every request, can you move it to the constructor like ConversionService
| this.byteBody = SupplierUtil.memoized(() -> { | ||
| try { | ||
| return InputStreamByteBody.create( | ||
| googleRequest.getInputStream(), |
There was a problem hiding this comment.
when/how is this closed?
There was a problem hiding this comment.
it's not, but i assume it doesn't really matter for functions
|
graemerocher
pushed a commit
to micronaut-projects/micronaut-oracle-cloud
that referenced
this pull request
Jun 24, 2024
The proposed approach to do the same as in micronaut-projects/micronaut-gcp#1106 did not exactly work. This is because the `InputEvent` does not allow accessing the `InputStream` directly. Instead it has a method `consumeBody(Function<InputStream>)` that should be called with implementation similar to this: ```java <T> T consumeBody(Function<InputStream, T> function) { /* verify that not null and not opened twice ... */ try { return function.call(this.body); } finally { this.body.close(); } /* ... */ } ``` Because it closes the stream we cannot read the stream gradually and split it. The solution is to read the stream as a whole into a byte array and then provide it to all the consumers. This will probably result in the same memory usage as in https://github.com/micronaut-projects/micronaut-gcp/pull/1106/files (since there we split each time and end up with one unused ByteBody caching the whole request). However, it will require reading the whole body before it is consumed (e.g. JSON parser cannot begin parsing the stream before whole body is read into memory). --------- Co-authored-by: micronaut-build <65172877+micronaut-build@users.noreply.github.com> Co-authored-by: yawkat <jonas.konrad@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.4.0->4.5.1Release Notes
micronaut-projects/micronaut-core (io.micronaut:micronaut-core-bom)
v4.5.1What's Changed
New Features 🎉
Docs 📖
Full Changelog: micronaut-projects/micronaut-core@v4.5.0...v4.5.1
v4.5.0: Micronaut Core v4.5.0What's Changed
New Features 🎉
Bug Fixes 🐞
Improvements ⭐
Docs 📖
Dependency updates 🚀
Regressions 🧐
Other Changes 💡
New Contributors
Full Changelog: micronaut-projects/micronaut-core@v4.4.10...v4.5.0
v4.4.10: Micronaut Core 4.4.10What's Changed
Dependency Upgrades 🚀
Bug Fixes 🐞
Improvements ⭐
Docs 📖
Full Changelog: micronaut-projects/micronaut-core@v4.4.9...v4.4.10
v4.4.9: Micronaut Core 4.4.9What's Changed
Bug Fixes 🐞
Full Changelog: micronaut-projects/micronaut-core@v4.4.8...v4.4.9
v4.4.8: Micronaut Core 4.4.8What's Changed
Bug Fixes 🐞
Docs 📖
New Contributors
Full Changelog: micronaut-projects/micronaut-core@v4.4.7...v4.4.8
v4.4.7: Micronaut Core 4.4.7What's Changed
Bug Fixes 🐞
Full Changelog: micronaut-projects/micronaut-core@v4.4.6...v4.4.7
v4.4.6: Micronaut Core 4.4.6What's Changed
Other Changes 💡
Full Changelog: micronaut-projects/micronaut-core@v4.4.5...v4.4.6
v4.4.5: Micronaut Core 4.4.5What's Changed
Bug Fixes 🐞
Full Changelog: micronaut-projects/micronaut-core@v4.4.4...v4.4.5
v4.4.4: Micronaut Core 4.4.4What's Changed
Bug Fixes 🐞
Full Changelog: micronaut-projects/micronaut-core@v4.4.3...v4.4.4
v4.4.3: Micronaut Core 4.4.3What's Changed
Bug Fixes 🐞
Full Changelog: micronaut-projects/micronaut-core@v4.4.2...v4.4.3
v4.4.2: Micronaut Core 4.4.2What's Changed
Full Changelog: micronaut-projects/micronaut-core@v4.4.1...v4.4.2
v4.4.1: Micronaut Core 4.4.1What's Changed
Dependency Upgrades 🚀
KSP
Micronaut Modules
Full Changelog: micronaut-projects/micronaut-core@v4.4.0...v4.4.1
Configuration
📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.