MongoDB update #449
Merged
MongoDB update #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radovanradic
reviewed
Jul 6, 2023
| @@ -73,7 +74,7 @@ class SerdeCodec<T> implements Codec<T> { | |||
| @Override | |||
| public T decode(BsonReader reader, DecoderContext decoderContext) { | |||
| try { | |||
| return deserializer.deserialize(new BsonReaderDecoder(reader), this.decoderContext, argument); | |||
| return deserializer.deserialize(new BsonReaderDecoder(reader, LimitingStream.DEFAULT_LIMITS), this.decoderContext, argument); | |||
There was a problem hiding this comment.
@sdelamo Compile was failing without this. The change is introduced in micronaut-projects/micronaut-serialization#496
Maybe they should left default constructor and pass default like this. Not sure if this is correct fix, but there is no config for this currently in mongodb. Maybe @yawkat can advise what is the correct approach here
There was a problem hiding this comment.
Now test is failing because platform includes serde M12 and this change is in M13
radovanradic
reviewed
Jul 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.