Fix processing multipart form data #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altro3
force-pushed
the
fix_multipartformdata
branch
2 times, most recently
from
f9f498e to
0c47020
Compare
altro3
force-pushed
the
fix_multipartformdata
branch
from
0c47020 to
e39412d
Compare
| */ | ||
| public static boolean isFileUpload(ClassElement type) { | ||
| String typeName = type.getName(); | ||
| return "io.micronaut.http.multipart.StreamingFileUpload".equals(typeName) |
There was a problem hiding this comment.
are these types not accessible in the context?
There was a problem hiding this comment.
Available, but that's not my code. so it was written before me. In general, I'm thinking about abandoning the direct use of the micronaut-http library and converting all places to strings, instead of explicit classes, and leaving only micronaut injection and micronaut core in dependencies. But this is just an idea for now. In any case, I don't see a problem with using the explicit class name and not the class itself at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.