Swagger UI 5.4.2 Redoc 2.1.1 #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
Aug 31, 2023
altro3
force-pushed
the
swagger-ui-props
branch
from
da43e23 to
dff5823
Compare
Redoc 2.1.1 Allow null values for extensions properties in openapi object Added Swagger UI property persistAuthorization Fixed micronaut-projects#1178
altro3
force-pushed
the
swagger-ui-props
branch
from
dff5823 to
38c55f7
Compare
graemerocher
approved these changes
Sep 7, 2023
sdelamo
reviewed
Sep 11, 2023
| @@ -36,6 +37,7 @@ | |||
| public abstract class OpenAPIMixin { | |||
|
|
|||
| @JsonAnyGetter | |||
| @JsonInclude | |||
There was a problem hiding this comment.
is @JsonInclude necessary? Do we have any test to verify it is necessary?
There was a problem hiding this comment.
@sdelamo Yeas, it necessary. We don't need to test it. These classes just copied from swagger-core project. This change i got from here: swagger-api/swagger-core#4468
I keep these classes up to date all the time. Why did I copy this piece from swagger-core? For two reasons:
-
This allowed me to remove a bunch of unnecessary dependencies from the project, i.e. from swagger-core, we used only the jackson settings.
-
Now there is a possibility to customize logic, due to this we managed to fix a couple of problems in serialization / deserialization.
sdelamo
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Fixed #1178