-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi generator 7.0.1 #1181
Openapi generator 7.0.1 #1181
Conversation
4170c09
to
f1c5033
Compare
swagger-parser = "1.0.67" | ||
swagger-parser-v3 = "2.1.16" | ||
javaparser = "3.25.5" | ||
commons-codec = "1.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commons-codec
is not necessary or used is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdelamo It is used by openapi-generator, not remembered directly or through swagger-parser. In any case, the old version has a vulnerability. This fix will help remove this vulnerability from micronaut-openapi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know about this? @melix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melix ping
07de1c6
to
9e7cbc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally commons-codec
should be a constraint. However this will not work with Maven, so making it an implementation
dependency makes sense.
9e7cbc3
to
cccf341
Compare
cccf341
to
3a4733e
Compare
fails because of #1217 |
0cc2dfc
to
572c4f5
Compare
I already fixed it here |
Update libraries. Removed redundant dependencies. Update commons-codec to remove vulnerability
572c4f5
to
5362497
Compare
5362497
to
9f3918a
Compare
@graemerocher hi! could you merge it? |
Code cleanup.
9f3918a
to
9b6bce9
Compare
@graemerocher ping |
Update libraries.
Removed redundant dependencies.
Update commons-codec to remove vulnerability