Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi generator 7.0.1 #1181

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Aug 27, 2023

Update libraries.
Removed redundant dependencies.
Update commons-codec to remove vulnerability

@altro3 altro3 requested a review from graemerocher August 27, 2023 17:43
@altro3 altro3 force-pushed the openapi-generator-7 branch from 4170c09 to f1c5033 Compare September 2, 2023 07:46
swagger-parser = "1.0.67"
swagger-parser-v3 = "2.1.16"
javaparser = "3.25.5"
commons-codec = "1.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commons-codec is not necessary or used is it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdelamo It is used by openapi-generator, not remembered directly or through swagger-parser. In any case, the old version has a vulnerability. This fix will help remove this vulnerability from micronaut-openapi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know about this? @melix

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melix ping

@altro3 altro3 force-pushed the openapi-generator-7 branch from 07de1c6 to 9e7cbc3 Compare September 16, 2023 10:30
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally commons-codec should be a constraint. However this will not work with Maven, so making it an implementation dependency makes sense.

@sdelamo
Copy link
Contributor

sdelamo commented Sep 20, 2023

fails because of #1217

@altro3 altro3 force-pushed the openapi-generator-7 branch 3 times, most recently from 0cc2dfc to 572c4f5 Compare September 21, 2023 10:34
@altro3
Copy link
Collaborator Author

altro3 commented Sep 21, 2023

I already fixed it here

Update libraries.
Removed redundant dependencies.
Update commons-codec to remove vulnerability
@altro3 altro3 force-pushed the openapi-generator-7 branch from 572c4f5 to 5362497 Compare September 22, 2023 08:22
@altro3 altro3 force-pushed the openapi-generator-7 branch from 5362497 to 9f3918a Compare September 22, 2023 08:27
@altro3
Copy link
Collaborator Author

altro3 commented Sep 22, 2023

@graemerocher hi! could you merge it?

Code cleanup.
@altro3 altro3 force-pushed the openapi-generator-7 branch from 9f3918a to 9b6bce9 Compare September 25, 2023 07:24
@altro3
Copy link
Collaborator Author

altro3 commented Sep 27, 2023

@graemerocher ping

@graemerocher graemerocher merged commit a04f1f1 into micronaut-projects:master Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants