Fix generating default values #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altro3
force-pushed
the
fix-generator-for-default-values
branch
from
83f9b31 to
47c0a90
Compare
altro3
force-pushed
the
fix-generator-for-default-values
branch
2 times, most recently
from
e0179ae to
94584b9
Compare
scprek
suggested changes
Aug 9, 2024
| assertFileContains(path + "api/DefaultApi.kt", | ||
| "@PathVariable(name = \"apiVersion\", defaultValue = \"v5\") @Nullable apiVersion: BrowseSearchOrdersApiVersionParameter? = BrowseSearchOrdersApiVersionParameter.V5,", | ||
| "@Header(name = \"Content-Type\", defaultValue = \"application/json\") @Nullable contentType: String? = \"application/json\"" | ||
| ); |
There was a problem hiding this comment.
The last case I was hoping for is XFavorToken default null to work. Is that easy to add?
@Header("X-Favor-Token") @Nullable xFavorToken: String? = nullNot sure you'd even have a defaultValue in the annotation for null since it has to be a string
|
Looking good, I got the same! Question about the default: null ones tho. @PathVariable(name = "apiVersion", defaultValue = "v5") @NotNull apiVersion: ApiVersion = ApiVersion.V5,
@Header("X-Favor-Token") @Nullable xFavorToken: String?,
@Header(name = "Content-Type", defaultValue = "application/json") @Nullable contentType: String? = "application/json" |
altro3
force-pushed
the
fix-generator-for-default-values
branch
from
94584b9 to
c34358a
Compare
scprek
approved these changes
Aug 12, 2024
altro3
force-pushed
the
fix-generator-for-default-values
branch
from
c34358a to
872a460
Compare
|
Will this get into 6.12 snapshot soon? |
|
@altro3 can you merge 6.12.x into this branch? |
altro3
force-pushed
the
fix-generator-for-default-values
branch
from
872a460 to
a801897
Compare
|
@sdelamo done |
|
@altro3 can you merge 6.12.x into this branch? |
altro3
force-pushed
the
fix-generator-for-default-values
branch
from
a801897 to
1634754
Compare
|
Noticed 1 possible issue, but can open a new ticket #1686 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1686