Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support generating Deprecated annotations and docs #1788

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add support generating Deprecated annotations and docs #1788

merged 1 commit into from
Oct 10, 2024

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Sep 25, 2024

Removed support swagger1 annotations for java generator

sdelamo
sdelamo requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing swagger 1 annotations is a breaking change.

Why are we mixing this removal with a PR to add Deprecated annotations?

...api-generator/src/test/java/io/micronaut/openapi/generator/AbstractMicronautCodegenTest.java Outdated
@@ -37,7 +37,7 @@ protected String generateFiles(MicronautCodeGenerator<?> codegen, String configP
} catch (IOException e) {
fail("Unable to create temporary directory for output");
}
output.deleteOnExit();
// output.deleteOnExit();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// output.deleteOnExit();
output.deleteOnExit();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@altro3
Copy link
Collaborator Author

altro3 commented Sep 30, 2024 •
edited
Loading

removing swagger 1 annotations is a breaking change.

Why are we mixing this removal with a PR to add Deprecated annotations?
You are wrong, this change is not breaking. No one could generate code with swagger1 annotations before, simply because no one had the ability to change this setting (it is not passed in the plugin for gradle and maven).

In fact, this is just garbage that was left after moving the generator to this repository and this code was only in templates. By the way, in the generator for Kotlin, which I already wrote myself, there was no support for the first swagger.

I just removed the extra garbage, and this will not affect the previously generated code in any way.

@altro3 altro3 changed the base branch from 6.12.x to 6.13.x September 30, 2024 14:11
@graemerocher
Copy link
Contributor

please resolve the conflicts

@altro3
Fixes for extensions and in templates.
a12b097 
Removed support swagger1 annotations
@altro3 altro3 force-pushed the support-deprecated branch from 7b8ba83 to a12b097 Compare October 3, 2024 06:43
@altro3 altro3 requested a review from graemerocher October 3, 2024 07:12
@altro3
Copy link
Collaborator Author

altro3 commented Oct 3, 2024

@graemerocher done

@graemerocher graemerocher requested a review from sdelamo October 3, 2024 08:55
@graemerocher graemerocher merged commit a9e7c39 into micronaut-projects:6.13.x Oct 10, 2024
6 checks passed
@graemerocher graemerocher added the type: enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
No open projects
4.7.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altro3 @graemerocher @sdelamo