-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support validation annotations extensions. #1789
Add support validation annotations extensions. #1789
Conversation
d661d9c
to
a10a871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are are these extensions documented anywhere x-pattern-message
, x-size-message
, x-not-null-message
, x-min-message
, x-max-message
? Is this something we are inventing for Micronaut OpenAPI or is it coming from a specification?
can you merge 6.13.x ? |
This satisfies the specification because these are extensions. The openapiGenerator core does not support these extensions, but for example x-pattern-message is supported by the spring generator: https://openapi-generator.tech/docs/generators/spring/ We are not obliged to support certain extensions, but we also have the right to create new extensions. I added the rest of the extensions in connection with this PR: OpenAPITools/openapi-generator#19630 In general, all these extensions are needed exclusively for more correct code generation. Support for new extensions does not affect the work of current users in any way, it simply adds the ability for them to describe the openapi specification so that the generated code is more accurate |
2ec555c
to
f778e97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these extensions defined or explained in our documentation? If not can you document, what we support?
Unfortunately, I don't have time to write full documentation yet. You see, at the moment we don't have any documentation for the generator at ALL. Therefore, we need to write it not only about these extensions, but about the entire generator as a whole. Therefore, I suggest not to bother with describing the generator features for now. I mean, specifically in these PRs, but in the future it will be time to write documentation for the generator. I was going to do this, but I haven't found the time yet |
Please resolve the conflicts |
8dffba7
to
5022b81
Compare
5022b81
to
ec0feaa
Compare
Add processing custom messages to jakarta validation annotations with extensions:
x-pattern-message
x-size-message
x-not-null-message
x-min-message
x-max-message