Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Schema Attributes to subtitute Schema #849

Closed
wants to merge 1 commit into from
Closed

Apply Schema Attributes to subtitute Schema #849

wants to merge 1 commit into from

Conversation

kevind-wgu
Copy link
Contributor

This is attempting to address issue #847. If you would like me to adjust things please let me know.

When specifying @Schema(implementation=String.class ...) all of the other parameters on the annotation are lost. The changes here will apply many of those annotation parameter values to the substitute Schema. The ones I applied are pattern, maximum, minimum, maxLength, minLength, exclusiveMaximum, exclusiveMinimum, example, defaultValue, multipleOf.

When specifying @Schema(implementation=String.class ...) all of the other parameters on the annotation
are lost. The changes here will apply many of those annotation parameter values to the substitute Schema.
The ones currently used are pattern, maximum, minimum, maxLength, minLength, exclusiveMaximum,
exclusiveMinimum, example, defaultValue, multipleOf.
@altro3
Copy link
Collaborator

altro3 commented Nov 18, 2022

@kevind-wgu hi! thanks for help! I fixed this bug here: #851. My changes base on your PR. But we already have @Schema annotation processing. You don't need to dubplicate logic for this

@kevind-wgu
Copy link
Contributor Author

Sounds great! Thank you!

@kevind-wgu kevind-wgu deleted the apply_schema_changes_substitute_schema branch November 18, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants