Fixed process nullable annotations #923
Conversation
openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
Show resolved
Hide resolved
| || element.getType().isOptional() | ||
| || element.hasStereotype(Nullable.class) | ||
| || element.hasStereotype("jakarta.annotation.Nullable") | ||
| || element.hasStereotype("org.jetbrains.annotations.Nullable"); |
There was a problem hiding this comment.
Please consider supporting other nullability annotations https://kotlinlang.org/docs/java-interop.html#nullability-annotations?
There was a problem hiding this comment.
This can be implemented using an annotation transformer to transform the annotations to AnnotationUtil.NULLABLE
There was a problem hiding this comment.
add all other annotations too
openapi/src/test/groovy/io/micronaut/openapi/visitor/OpenApiNullableTypesSpec.groovy
Outdated
Show resolved
Hide resolved
openapi/src/main/java/io/micronaut/openapi/visitor/AbstractOpenApiVisitor.java
Outdated
Show resolved
Hide resolved
altro3
force-pushed
the
fix_nullable
branch
2 times, most recently
from
cc9877b to
2545aa3
Compare
|
@sdelamo @dstepanov I've added support all nullable annotations from @sdelamo 's link. But I think i found bug in micronaut: These two annotations not found. I think problem is here: both annotions have Target TYPE_USE |
| return element.isNullable() | ||
| || element.getType().isOptional() | ||
| || element.hasStereotype(Nullable.class) | ||
| || element.hasStereotype("javax.annotation.Nullable") |
There was a problem hiding this comment.
There was a problem hiding this comment.
@dstepanov No, can't. Because it since micronaut 4.0, but this fix for release 4.8.3 which based on micronaut 3.8.3
There was a problem hiding this comment.
It should work in 3.8.3 too.
There was a problem hiding this comment.
@dstepanov no! this class added in micronaut 4.0:
Can't find this class in 3.8.x branch
There was a problem hiding this comment.
Yes, the class is just an example how to do it. Just copy it, modify the annotation name and define it in the service entires.
|
@altro3 Javac might be acting strange with those types. Maybe you can create an issue with a reproducible test in the core? |
openapi/src/main/java/io/micronaut/openapi/visitor/TypeElementUtils.java
Show resolved
Hide resolved
Fixed #921