Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make visitor package internal #926

Merged
merged 1 commit into from
Feb 6, 2023
Merged

ci: make visitor package internal #926

merged 1 commit into from
Feb 6, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Feb 2, 2023

This PR changes the package io.micronaut.openapi.visitor to be internal.

There were breaking changes:

Constructor io.micronaut.openapi.visitor.OpenApiControllerVisitor(java.util.List,java.util.List): Is not binary compatible. 
If you did this intentionally, please accept the change and provide an explanation: [Accept this change](file:///Users/sdelamo/github/micronaut-projects/micronaut-openapi/openapi/build/reports/binary-compatibility-openapi.html#accept-io_micronaut_openapi_visitor_OpenApiControllerVisitorConstructor_io_micronaut_openapi_visitor_OpenApiControllerVisitor_java_util_List_java_util_List_)

Constructor has been removed

@sdelamo sdelamo requested a review from melix February 2, 2023 05:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@graemerocher graemerocher merged commit 9140e83 into 4.8.x Feb 6, 2023
@graemerocher graemerocher deleted the make-visitor-package-internal branch February 6, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix Awaiting requested review from melix

@alvarosanchez alvarosanchez Awaiting requested review from alvarosanchez

@timyates timyates Awaiting requested review from timyates

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @graemerocher