Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for allOf and other improvements. #986

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Apr 15, 2023

  • Changed context.fail to context.warn when path variable is not found (!critical because now if pathVariable is not found the build will fail)
  • Fix duplicates references in allOf block
  • Sorting schemas in allOf block: schemas with ref must be first

@altro3
Copy link
Collaborator Author

altro3 commented Apr 15, 2023

@graemerocher Hi! Could you merge this PR and #982 and finalize release?

Also, please, close next tickets:

Fixed: #977, #104

Won't do: #944, #904

Not a bug: #974

@graemerocher graemerocher merged commit b934bf6 into micronaut-projects:4.8.x Apr 16, 2023
@graemerocher
Copy link
Contributor

@altro3 as a contributor you should be able to close those tickets

@altro3
Copy link
Collaborator Author

altro3 commented Apr 16, 2023

@graemerocher Hi! Thank you for your trust! Yes, now I can do it myself :-). Please don't create a new release just yet. I found a few more small inaccuracies, I would like to fix them before the release is finalized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants