Remove the un-required ByteBody split #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @yawkat pointed out the BaseFilterProcessor uses byteBody().split(FASTEST) to get a body for request filters and leave an extra copy for actual request parsing. Therefore, assuming that we will only parse the body once, we do not need to copy the body when it is consumed by body binder. For the case of input streams and form data we only need to parse the body once, so we do that and cache the result in a multi-values field that can be reused. Removing the split when it is not needed would prevent from unnecessary body caching.
|
graemerocher
approved these changes
Aug 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @yawkat pointed out the BaseFilterProcessor uses byteBody().split(FASTEST) to get a body for request filters and leave an extra copy for actual request parsing. Therefore, assuming that we will only parse the body once, we do not need to copy the body when it is consumed by body binder. For the case of input streams and form data we only need to parse the body once, so we do that and cache the result in a multi-values field that can be reused.
Removing the split when it is not needed would prevent from unnecessary body caching.