Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AuthenticationRequest to LoginFailedEvent #1433

Merged
merged 2 commits into from
Sep 1, 2023
Merged

feat: add AuthenticationRequest to LoginFailedEvent #1433

merged 2 commits into from
Sep 1, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Sep 1, 2023

Close: #1188

@sdelamo sdelamo added the type: improvement A minor improvement to an existing feature label Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 3 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sdelamo sdelamo merged commit 4b8eed4 into master Sep 1, 2023
9 of 10 checks passed
@sdelamo sdelamo deleted the issue-1188 branch September 1, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.1.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoginFailedEvent doesn't know the user who tries to login
2 participants
@sdelamo @timyates