Migration to Micronaut 4 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sdelamo Can you please investigate the CORS errors? |
|
Ok, so I've take a look at the CORS failures... What I suspect is happening is that HttpClient has changed to keep-alive as default micronaut-projects/micronaut-core#8100 (comment) And Jetty doesn't return I'll go with this, and get a commit together that goes with this expectation |
Now we have a keep-alive client, the Connection is no longer returned by Jetty
|
@dstepanov Fixed the cors errors... There are still binding errors, and fields not being bound from Json Can you take a look? |
|
SonarCloud Quality Gate failed. |
graemerocher
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR uses refactored routing API from Core eliminating duplicate code.
There are some unresolved errors caused by CORS not doing the same as before and errors caused by serde migrations.