Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ServletHttpHandler to use new RequestLifecycle api #363

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Dec 7, 2022

This is untested, I can't get this to build with my local snapshot of micronaut-core

This is untested, I can't get this to build with my local snapshot of micronaut-core
@yawkat yawkat marked this pull request as ready for review December 15, 2022 08:43
@yawkat yawkat requested a review from timyates December 15, 2022 08:44
@yawkat
Copy link
Member Author

yawkat commented Dec 15, 2022

still failing, will take a look.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@yawkat yawkat merged commit 48b94e7 into master Dec 15, 2022
@yawkat yawkat deleted the route-refactor branch December 15, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants