Upgrade to jakarta.servlet namespace #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Java CI failed: https://ge.micronaut.io/s/oehz5fadvrw44 |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/w5it655amdgre |
graemerocher
commented
Feb 28, 2023
| transformation = MapFormat.MapTransformation.FLAT, | ||
| keyFormat = StringConvention.RAW) Map<String, String> attributes) { | ||
| if (CollectionUtils.isNotEmpty(attributes)) { | ||
| attributes.forEach(tomcatConnector::setAttribute); |
There was a problem hiding this comment.
this no longer exists on Tomcat
graemerocher
commented
Feb 28, 2023
| try { | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("Request [{} - {}] completed successfully", req.getMethodName(), req.getUri()); | ||
| LOG.debug("Request [{} - {}] completed successfully", methodName, uri); |
There was a problem hiding this comment.
tomcat now errors if the request is accessed after completion, this fixes that
graemerocher
commented
Feb 28, 2023
| @@ -79,7 +81,7 @@ | |||
| * @since 1.0.0 | |||
| */ | |||
| @Internal | |||
| public class DefaultServletHttpRequest<B> implements | |||
| public class DefaultServletHttpRequest<B> extends MutableConvertibleValuesMap<Object> implements | |||
There was a problem hiding this comment.
could no longer user servlet request attributes because they can't be accessed after the request completes
dstepanov
approved these changes
Feb 28, 2023
timyates
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to the
jakarta.servletnamespace and upgrade all Servlet modules