Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tomcat 10 WAR deployment #541

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fix Tomcat 10 WAR deployment #541

merged 1 commit into from
Aug 15, 2023

Conversation

timyates
Copy link
Contributor

For Micronaut 4.0.0 we switched to the jakarta servlet classes.

However, we missed renaming this SPI service file, so Tomcat 10 will not deploy WAR files directly.

For Micronaut 4.0.0 we switched to the jakarta servlet classes.

However, we missed renaming this SPI service file, so Tomcat 10 will not deploy WAR files directly.
@timyates timyates added the type: bug Something isn't working label Aug 15, 2023
@timyates timyates added this to the 4.0.2 milestone Aug 15, 2023
@timyates timyates requested a review from sdelamo August 15, 2023 14:59
@timyates timyates self-assigned this Aug 15, 2023
@timyates timyates linked an issue Aug 15, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit 170a260 into master Aug 15, 2023
@sdelamo sdelamo deleted the jakarta-SPI branch August 15, 2023 15:11
sdelamo pushed a commit that referenced this pull request Aug 15, 2023
For Micronaut 4.0.0 we switched to the jakarta servlet classes.

However, we missed renaming this SPI service file, so Tomcat 10 will not deploy WAR files directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deployment as war to tomcat 10 does not work
2 participants