Stop double encoding body when we have a response encoder #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a response-encoder is present, it handles encoding the response. Without this change, we were then falling through and encoding the body into the response a second time. This was discovered in AWS here micronaut-projects/micronaut-aws#1843 It wasn't seen here as we add a servlet for handling static resources in jetty/undertow/tomcat
|
Can this be tested? |
|
@dstepanov Trying to think of a way to test it, but struggling atm... 🤔 |
|
@dstepanov As far as I can tell, tomcat/jetty/undertow take the async path. It's only when we get to AWS or GCP that the synch path is taken and this bug is exhibited 🤔 |
|
Maybe we can force the servlet engine to always use sync |
|
@dstepanov Can do something like this: So use a "secret" property to switch to sync mode (but default to async mode) Or should this be a public config? |
|
Kudos, SonarCloud Quality Gate passed! |
|
The secret property is fine with me. I thought a servlet engine like Jetty would have an internal option to disable async, but it might be part of the spec, so probably not. |
sdelamo
approved these changes
Aug 22, 2023
|
ping @dstepanov |
dstepanov
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a response-encoder is present, it handles encoding the response.
Without this change, we were then falling through and encoding the body into the response a second time.
This was discovered in AWS here micronaut-projects/micronaut-aws#1843
It wasn't seen here as we add a servlet for handling static resources in jetty/undertow/tomcat