Add Servlet Context if deployed as named WAR file #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are deploying as a named WAR file (ie: `myproject-0.1.war`) then this will be the context path for the application. This change detects this, and sets the context path for the application accordingly. Any context-path config in the application context will be ignored in this case. If the deployed WAR file is added to the ROOT context (ie: by deploying `ROOT.war`), then any context-path from application properties will be used.
|
I manually tested this with Tomcat and Jetty, but I cannot think of a nice way of automatically testing it without non-insignificant effort. If we agree the effort is worth it, I can work on it |
graemerocher
approved these changes
Aug 29, 2023
sdelamo
requested changes
Aug 29, 2023
...ngine/src/main/java/io/micronaut/servlet/engine/initializer/MicronautServletInitializer.java
Outdated
Show resolved
Hide resolved
sdelamo
approved these changes
Aug 29, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are deploying as a named WAR file (ie:
myproject-0.1.war) then this will be the context path for the application. This change detects this, and sets the context path for the application accordingly. Any context-path config in the application context will be ignored in this case.If the deployed WAR file is added to the ROOT context (ie: by deploying
ROOT.war), then any context-path from application properties will be used.