Proper streaming ByteBody implementation #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With splitting and everything. After this, we can look at making some more binders between netty and servlet common, in particular the NettyBodyAnnotationBinder.
…byte-body # Conflicts: # servlet-engine/src/main/java/io/micronaut/servlet/engine/DefaultServletHttpRequest.java
dstepanov
approved these changes
May 31, 2024
servlet-engine/src/main/java/io/micronaut/servlet/engine/LazyDelegateInputStream.java
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/body/ExtendedInputStream.java
Outdated
Show resolved
Hide resolved
graemerocher
requested changes
May 31, 2024
| */ | ||
| public DefaultServletHttpHandler(ApplicationContext applicationContext, ConversionService conversionService) { | ||
| public DefaultServletHttpHandler(ApplicationContext applicationContext, ConversionService conversionService, @Named(TaskExecutors.BLOCKING) Executor ioExecutor) { |
There was a problem hiding this comment.
these should seems specific to Servlet, how will this work with GCP/AWS where we have the failing tests now?
There was a problem hiding this comment.
I searched for DefaultServletHttpRequest in micronaut-projects and this was the only usage, so I assume GCP/AWS still go through this handler
There was a problem hiding this comment.
AWS and GCP don't depend on servlet-engine
servlet-engine/src/main/java/io/micronaut/servlet/engine/DefaultServletHttpRequest.java
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/LazyDelegateInputStream.java
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/LazyDelegateInputStream.java
Outdated
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/body/ByteQueue.java
Outdated
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/body/ExtendedInputStream.java
Outdated
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/body/ExtendedInputStream.java
Outdated
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/body/InputStreamByteBody.java
Outdated
Show resolved
Hide resolved
servlet-engine/src/main/java/io/micronaut/servlet/engine/body/InputStreamByteBody.java
Outdated
Show resolved
Hide resolved
|
Re coverage: StreamPair is the complicated code here, and I tried to cover it pretty well. The rest of the code is covered by TCK tests |
|
sonar is broken unfortunately |
|
seems to be working now, please address the sonar issues |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With splitting and everything.
After this, we can look at making some more binders between netty and servlet common, in particular the NettyBodyAnnotationBinder.