Allow disabling of datasources by excluding packages #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the testing of non-db beans without requiring the connection pools to be fully configured. Does not cover r2dbc as that is defined elsewhere. micronaut-projects/micronaut-data#2893 It is done this way (with package requirements) as there is no way currently to allow EachBean to skip factory creation based on a property of the bean (ie Toggleable#isEnabled).
|
sdelamo
approved these changes
Apr 24, 2024
dstepanov
reviewed
Apr 24, 2024
| @@ -18,8 +18,11 @@ | |||
| */ | |||
| @Configuration | |||
| @Requires(classes = HikariDataSource.class) | |||
There was a problem hiding this comment.
Maybe add requires to BasicJdbcConfiguration and that should be enough for all implementations
There was a problem hiding this comment.
@dstepanov No, the @Requires doesn't seem to carry through... In my tests with Hikari, we still end up with a DatasourceConfiguration and a HikariUrlDataSource bean
dstepanov
approved these changes
Apr 25, 2024
sdelamo
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the testing of non-db beans without requiring the connection pools to be fully configured.
Does not cover r2dbc as that is defined elsewhere.
micronaut-projects/micronaut-data#2893
It is done this way (with package requirements) as there is no way currently to allow EachBean to skip factory creation based on a property of the bean (ie Toggleable#isEnabled).