-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React SSR feature #2524
Add React SSR feature #2524
Conversation
@melix could you look at the generated Gradle config, not sure if it represents best practise |
I will. At first glance there are improvements which can be made to avoid |
OK. What's wrong with dependsOn? Do you have a link to the current Gradle best practices? |
I wrote a blog post about this a while back : https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html In general you should have a task which produces an output, then the tasks which consume this output must define it as an input : |
I think in this case it wouldn't make a difference. The custom |
|
This PR depends on micronaut-projects/micronaut-views#833 as otherwise the config needed is excessively complicated. |
@melix Thanks for your review, I've force pushed a new version of the commit that uses |
can you correct the check style failures? |
Re-opened on 4.5.x
This PR adds support for creating a sample project that uses React server side rendering (SSR).