Implement binary protocol between client and server #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a custom protocol for communicating between the client and the server. Instead of using JSON, it now uses a binary protocol. This removes the requirement of having Micronaut JSON on the user classpath (on the client side) and further reduces the number of dependencies of the server. This is a major breaking change, and it's no longer possible to directly use tools like cURL or httpie to talk to the server. This is blocked by micronaut-projects/micronaut-core#9331
melix
added
type: improvement
|
Sonar analysis seems completely off. |
graemerocher
requested changes
May 30, 2023
| public void writeTo(Argument<T> type, MediaType mediaType, T object, MutableHeaders outgoingHeaders, OutputStream outputStream) throws CodecException { | ||
| try { | ||
| var dos = new DataOutputStream(outputStream); | ||
| outgoingHeaders.set("Content-Type", TEST_RESOURCES_BINARY_MEDIA_TYPE); |
There was a problem hiding this comment.
you can use the HttpHeaders type that has constants for this
| outgoingHeaders.set("Content-Type", TEST_RESOURCES_BINARY_MEDIA_TYPE); | ||
| TestResourcesCodec.writeObject(object, dos); | ||
| } catch (IOException e) { | ||
| throw new CodecException("Invalid binary stream", e); |
There was a problem hiding this comment.
perhaps make these error messages more descriptive so we know it is coming from test resources
|
SonarCloud Quality Gate failed. |
graemerocher
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a custom protocol for communicating between the client and the server. Instead of using JSON, it now uses a binary protocol. This removes the requirement of having Micronaut JSON on the user classpath (on the client side) and further reduces the number of dependencies of the server.
This is a major breaking change, and it's no longer possible to directly use tools like cURL or httpie to talk to the server.
This is blocked by micronaut-projects/micronaut-core#9331