-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use and export kotest-bom for kotest dependencies management #844
Conversation
fdf50f6
to
06812d8
Compare
Ideally explicit versions should be removed from
and
above it. But when I try to do that I get
I guess these constraints are getting added by an internal micronaut tooling ("io.micronaut.build.internal.bom" plugin?). But the message doesn't have enough info to easily untangle this without tracing back the source of the message. I didn't put time into figuring it out yet, so I left it as-is for now looking at the fact that it already was done for junit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move the managed-kotest
entries back to where they were? They are intentionally grouped by managed-
.
Thanks
06812d8
to
35688c0
Compare
@melix done. I moved them into "managed-by-boms" group because I was going to drop the explicit specification of the version, but wasn't able to do that as described above. Moved them back. |
35688c0
to
a4f02b2
Compare
No, please keep them as is. Do not rename them as it's a breaking change. We use conventions, and these lead to properties in BOM files, or type-safe accessors in catalogs. Any change in the name is a breaking change. Thanks! Update: sorry I thought you renamed the aliases, realizing you didn't :) |
Thanks for this @Spikhalskiy 👍 |
micronaut-test-kotest5 now uses and exposes kotest-bom
Related PR into micronaut-platform: micronaut-projects/micronaut-platform#901
Closes #843