Support multiple Kotest spec instances #860
Conversation
|
|
| @@ -51,6 +51,7 @@ object MicronautKotest5Extension: TestListener, ConstructorExtension, TestCaseEx | |||
|
|
|||
| override suspend fun afterSpec(spec: Spec) { | |||
| contexts[spec.javaClass.name]?.afterSpecClass(spec) | |||
| contexts[spec.javaClass.name]?.close() | |||
There was a problem hiding this comment.
The line above already closes the application context here:
So this addition doesn't really do anything at the moment.
| @@ -116,4 +116,7 @@ class MicronautKotest5Context( | |||
| ) | |||
| } | |||
|
|
|||
| fun close() { | |||
| applicationContext.close() | |||
There was a problem hiding this comment.
This throws NPE now, the applicationContext is stopped and nullified by afterSpecClass
There was a problem hiding this comment.
Yeah this isn't the fix, but I know what is now.
I'll update it and add a test.
|
I think this should do it @Spikhalskiy |
|
@sksamuel I confirm that with this change the issue I reported in kotest/kotest#3711 is resolved, all initialized contexts in the sample project are getting shutdown. |
test-kotest5/src/main/kotlin/io/micronaut/test/extensions/kotest5/MicronautKotest5Extension.kt
Outdated
Show resolved
Hide resolved
|
@dstepanov Anything we can do to advance this PR? |
|
Looks fine to me |
Hi Micronaut folks!
I think the application context should be closed when a Kotest spec finishes executing, otherwise the resources are not cleaned up.Kotest5Context needs to support multiple instances of specs.
See bug report here: kotest/kotest#3711