Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow compilation against the latest 4.0.0 snapshot #460

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

timyates
Copy link
Contributor

@timyates timyates commented Nov 4, 2022

No description provided.

@timyates timyates requested a review from sdelamo November 4, 2022 14:50
@timyates timyates self-assigned this Nov 4, 2022
@@ -168,7 +167,7 @@ public boolean exists(@NonNull String viewName) {
}
}

@Introspected
@Serdeable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know why I had to use @Serdeable in place of @Introspected... Does 4.0.0 of security switch to serde?

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use serde instead jackson

views-core/build.gradle Show resolved Hide resolved
test-suite/build.gradle Outdated Show resolved Hide resolved
@timyates timyates requested a review from sdelamo November 7, 2022 11:57
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit b851348 into master Nov 28, 2022
@sdelamo sdelamo deleted the fix-4.0.0 branch November 28, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants