Polish docs. #470
Merged
Polish docs. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
can you target this pr to 3.8.x branch as base?. |
|
Will do. |
- make ViewsController.groovy compatible with Java - remove license code from freemarker files
maciejwalkowiak
force-pushed
the
polish-docs
branch
from
a1596f9
to
b976d03
Compare
sdelamo
approved these changes
Dec 23, 2022
|
thanks for the PR @maciejwalkowiak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs include parts from
ViewsController.groovybut say that it is a Java file. With this change the code is less confusing for someone not used to Groovy syntax and is almost compatible with Java - there are still missing semicolons.Also the license header is removed from freemarker files as it clutters the docs (other template engines do not have license headers).