Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dataTurbo field to form and add test for fieldset TCK. #787

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Add a dataTurbo field to form and add test for fieldset TCK. #787

merged 6 commits into from
Apr 25, 2024

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Apr 23, 2024

closes #771

@wetted wetted self-assigned this Apr 23, 2024
@wetted wetted marked this pull request as ready for review April 23, 2024 20:15
@wetted wetted requested a review from sdelamo April 23, 2024 20:23
sdelamo
sdelamo requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the javadoc and link to the Turbo documentation

data-turbo="false" disables Turbo Drive on links and forms including descendants.

https://turbo.hotwired.dev/reference/attributes

@wetted wetted requested a review from sdelamo April 24, 2024 14:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
42.9% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

wetted added a commit to micronaut-projects/micronaut-starter that referenced this pull request Apr 24, 2024
@wetted
Update to micronaut-views thymeleaf fieldset form to include `data-tu…
fb47d18 
…rbo` attribute. See micronaut-projects/micronaut-views#787
@wetted wetted mentioned this pull request Apr 24, 2024
Merged
sdelamo pushed a commit to micronaut-projects/micronaut-starter that referenced this pull request Apr 25, 2024
@wetted
Update to micronaut-views thymeleaf fieldset form to include `data-tu…
81c28db 
…rbo` attribute. See micronaut-projects/micronaut-views#787 (#2467)
@sdelamo sdelamo merged commit fce7b46 into 5.3.x Apr 25, 2024
24 of 25 checks passed
@sdelamo sdelamo deleted the dataTurbo-field branch April 25, 2024 04:59
@wetted wetted mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees

@wetted wetted

Labels
None yet
Projects
No open projects
4.5.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a dataTurbo field to form
2 participants
@wetted @sdelamo