ReactJS: Another round of fixes and improvements #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently disabled whilst waiting for a new GraalVM release.
The old name was incorrect and confusing.
|
you need to run spotlessApply |
sdelamo
reviewed
Aug 7, 2024
sdelamo
approved these changes
Aug 7, 2024
views-react/src/main/java/io/micronaut/views/react/JSBeanFactory.java
Outdated
Show resolved
Hide resolved
views-react/src/main/java/io/micronaut/views/react/JSBeanFactory.java
Outdated
Show resolved
Hide resolved
views-react/src/main/java/io/micronaut/views/react/JSBeanFactory.java
Outdated
Show resolved
Hide resolved
views-react/src/main/java/io/micronaut/views/react/JSSandboxing.java
Outdated
Show resolved
Hide resolved
views-react/src/main/java/io/micronaut/views/react/JSSandboxing.java
Outdated
Show resolved
Hide resolved
views-react/src/main/java/io/micronaut/views/react/ProxyObjectWithIntrospectableSupport.java
Show resolved
Hide resolved
sdelamo
requested changes
Aug 7, 2024
There was a problem hiding this comment.
You have to fix the checkstyle violations
> Task :micronaut-views-react:checkstyleMain FAILED
[ant:checkstyle] [ERROR] /Users/sdelamo/github/micronaut-projects/micronaut-views/views-react/src/main/java/io/micronaut/views/react/ProxyObjectWithIntrospectableSupport.java:110:5: Class PolyglotBeanMethod should be declared as final. [FinalClass]
[ant:checkstyle] [ERROR] /Users/sdelamo/github/micronaut-projects/micronaut-views/views-react/src/main/java/io/micronaut/views/react/ProxyObjectWithIntrospectableSupport.java:143:5: Init blocks, constructors, fields and methods should be before inner types. [InnerTypeLast]
[ant:checkstyle] [ERROR] /Users/sdelamo/github/micronaut-projects/micronaut-views/views-react/src/main/java/io/micronaut/views/react/ProxyObjectWithIntrospectableSupport.java:148:5: Init blocks, constructors, fields and methods should be before inner types. [InnerTypeLast]
[ant:checkstyle] [ERROR] /Users/sdelamo/github/micronaut-projects/micronaut-views/views-react/src/main/java/io/micronaut/views/react/ProxyObjectWithIntrospectableSupport.java:153:5: Init blocks, constructors, fields and methods should be before inner types. [InnerTypeLast]
[ant:checkstyle] [ERROR] /Users/sdelamo/github/micronaut-projects/micronaut-views/views-react/src/main/java/io/micronaut/views/react/ProxyObjectWithIntrospectableSupport.java:161:5: Init blocks, constructors, fields and methods should be before inner types. [InnerTypeLast]
…efore inner types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.