Skip to content

Commit

Permalink
Remove two unnecessary .NET Standard 1.x dependencies. (#2613)
Browse files Browse the repository at this point in the history
System.Diagnostics.StackTrace and TraceSource are not needed in projects that target .NET Standard 2.0. Referencing them substantially increases the transitive dependencies.
  • Loading branch information
teo-tsirpanis authored Jun 29, 2022
1 parent d85fadc commit a2b56d5
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Changelog

## VNext
- [Remove two unnecessary .NET Standard 1.x dependencies.](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2613)
- Address vulnerability in `Newtonsoft.Json` ([GHSA-5crp-9r3c-p9vr](https://github.com/advisories/GHSA-5crp-9r3c-p9vr)).
Mitigation is to upgrade dependencies in `Microsoft.ApplicationInsights.AspNetCore` ([#2615](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2615))
- Upgrade `Microsoft.Extensions.Configuration.Json` from v2.1.0 to v3.1.0.
- Upgrade `System.Text.Encodings.Web` from 4.5.1 to 4.7.2.


## Version 2.21.0-beta2
- [LOGGING: Make TelemetryConfiguration configurable in ApplicationInsightsLoggingBuilderExtensions](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1944)
Expand Down
4 changes: 0 additions & 4 deletions LOGGING/src/TraceListener/TraceListener.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
<ProjectReference Include="..\..\..\BASE\src\Microsoft.ApplicationInsights\Microsoft.ApplicationInsights.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
</ItemGroup>

<ItemGroup>
<Content Include="app.config.install.xdt" />
<Content Include="app.config.uninstall.xdt" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
<Reference Include="System.Net.Http" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Diagnostics.StackTrace" Version="4.3.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net452'">
<!--Framework References-->
<Reference Include="System.Runtime.Caching" />
Expand Down

0 comments on commit a2b56d5

Please sign in to comment.