ILogger provider populates structured logging key/values irrespective… #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of whether Scopes are enabled or not
cijothomas
commented
Oct 2, 2020
| @@ -168,23 +168,23 @@ private void PopulateTelemetry<TState>(ISupportProperties telemetryItem, TState | |||
| dict["EventName"] = eventId.Name; | |||
| } | |||
|
|
|||
| if (this.applicationInsightsLoggerOptions.IncludeScopes) | |||
| if (state is IReadOnlyCollection<KeyValuePair<string, object>> stateDictionary) | |||
There was a problem hiding this comment.
this logic is moved out of the If(scopeenabled) - thats the only change in this PR :)
reyang
approved these changes
Oct 2, 2020
rajkumar-rangaraj
approved these changes
Oct 2, 2020
|
I don't get it. Why would you have to set "IncludeScopes" to get structured values? I think those settings are orthogonal. |
Exactly. This PR is fixing the bug which populated structured values only when scopes were enabled. |
|
Got it. Sorry for the misunderstanding. (I think I must've misinterpreted the title as a defect report) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of whether Scopes are enabled or not
Fix Issue # .
Changes
(Please provide a brief description of the changes here.)
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build