AAD: AuthenticationTransmissionPolicy logging

[TimothyMothra]

Fix Issue #2190

Changes

• added logs to indicate AuthenticationTransmissionPolicy caught the response from ingestion and also log the custom response message from ingestion.

example logs:

2021-07-02T22:56:29.5832072Z:TransmissionSendingFailed. TransmissionId: {0}. Message: {1}.{RSMvsjasK/Y=}{401}{WebApp.AspNetCore}
2021-07-02T22:56:29.5855541Z:TransmissionDataLossError. Telemetry items are being lost here as the response code is not in the whitelisted set of retriable codes.TransmissionId: {0}. Status Code: {1}.{RSMvsjasK/Y=}{401}{WebApp.AspNetCore}
2021-07-02T22:56:29.5861041Z:AuthenticatedTransmissionError. Received a failed ingestion response. TransmissionId: {0}. Status Code: {1}. Status Description: {2}{RSMvsjasK/Y=}{401}{Unauthorized - please provide the valid authorization token}{WebApp.AspNetCore}
2021-07-02T22:56:29.5993048Z:AuthenticatedTransmissionError. Received a failed ingestion response. TransmissionId: {0}. Status Code: {1}. Status Description: {2}{eUX4L6JrBao=}{401}{Unauthorized - please provide the valid authorization token}{WebApp.AspNetCore}
2021-07-02T22:56:29.5993228Z:AuthenticatedTransmissionError. Received a failed ingestion response. TransmissionId: {0}. Status Code: {1}. Status Description: {2}{izL02KJ8vRk=}{401}{Unauthorized - please provide the valid authorization token}{WebApp.AspNetCore}
2021-07-02T22:56:29.5993226Z:AuthenticatedTransmissionError. Received a failed ingestion response. TransmissionId: {0}. Status Code: {1}. Status Description: {2}{NGzS37P4U+M=}{401}{Unauthorized - please provide the valid authorization token}{WebApp.AspNetCore}
2021-07-02T22:56:29.6393824Z:TransmissionSendingFailed. TransmissionId: {0}. Message: {1}.{7mVQefZ5ooY=}{401}{WebApp.AspNetCore}
2021-07-02T22:56:29.6540860Z:TransmissionDataLossError. Telemetry items are being lost here as the response code is not in the whitelisted set of retriable codes.TransmissionId: {0}. Status Code: {1}.{7mVQefZ5ooY=}{401}{WebApp.AspNetCore}
2021-07-02T22:56:29.6542202Z:AuthenticatedTransmissionError. Received a failed ingestion response. TransmissionId: {0}. Status Code: {1}. Status Description: {2}{7mVQefZ5ooY=}{401}{Unauthorized - please provide the valid authorization token}{WebApp.AspNetCore}
2021-07-02T22:56:29.6551079Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6551711Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6551759Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6550946Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6553061Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6559699Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6559778Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6560096Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6560186Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}
2021-07-02T22:56:29.6560282Z:BufferEnqueueNoCapacity. Size: {0}. Capacity: {1}.{0}{0}{WebApp.AspNetCore}

Note that ErrorHandlingTransmissionPolicy also witnesses the 401 and logs a message that telemetry will be lost. I don't have a good solution for removing this.

ApplicationInsights-dotnet/BASE/src/ServerTelemetryChannel/Implementation/TransmissionPolicy/ErrorHandlingTransmissionPolicy.cs

Lines 102 to 109 in 7c6589e

	default:
	// We are losing data here but that is intentional as the response code is
	// not in the whitelisted set to attempt retry.
	TelemetryChannelEventSource.Log.TransmissionDataNotRetriedForNonWhitelistedResponse(e.Transmission.Id,
	httpWebResponseWrapper.StatusCode.ToString(CultureInfo.InvariantCulture));
	// For non white listed response, set the result of FlushAsync to false.
	e.Transmission.IsFlushAsyncInProgress = false;
	break;

Checklist

• I ran Unit Tests locally.
• CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

• Design discussion issue #
• Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

• FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

• We support comment build triggers
  • /AzurePipelines run will queue all builds
  • /AzurePipelines run <pipeline-name> will queue a specific build

[rajkumar-rangaraj]

LGTM