Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove HttpContextStub and HttpRequestStub from AspNetCore tests (prep FrameworkReference) #2414

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Sep 16, 2021

Fix Issue #2251.

I'm preparing to change AspNetCore and AspNetCore.Tests to use FrameworkReference.
There are some incompatibilities in the current tests which I'm resolving here.

image

Changes

  • remove HttpContextStub replace with DefaultContext.
    HttpContextStub formerly inherited DefaultContext, but this class has been marked sealed.
  • remove HttpRequestStub.
    HttpRequestStub formerly inherited DefaultHttpRequest, but this class is inaccessible due to it's protection level.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra TimothyMothra changed the title fix AspNetCore tests: remove HttpContextStub and HttpRequestStub fix AspNetCore tests: remove HttpContextStub and HttpRequestStub (prep FrameworkReference) Sep 16, 2021
@TimothyMothra TimothyMothra changed the title fix AspNetCore tests: remove HttpContextStub and HttpRequestStub (prep FrameworkReference) remove HttpContextStub and HttpRequestStub from AspNetCore tests (prep FrameworkReference) Sep 16, 2021
@TimothyMothra TimothyMothra merged commit fb0e8a4 into develop Sep 16, 2021
@TimothyMothra TimothyMothra deleted the tilee/fix_aspnetcore_tests branch September 16, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants