remove HttpContextStub and HttpRequestStub from AspNetCore tests (prep FrameworkReference) #2414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #2251.
I'm preparing to change
AspNetCore
andAspNetCore.Tests
to useFrameworkReference
.There are some incompatibilities in the current tests which I'm resolving here.
Changes
HttpContextStub
replace withDefaultContext
.HttpContextStub
formerly inheritedDefaultContext
, but this class has been markedsealed
.HttpRequestStub
.HttpRequestStub
formerly inheritedDefaultHttpRequest
, but this class is inaccessible due to it's protection level.Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines run
will queue all builds/AzurePipelines run <pipeline-name>
will queue a specific build