-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new signing pipeline (part1) #2476
Conversation
commands: | ||
- !!buildcommand | ||
name: 'Dotnet Build' | ||
command: '.pipelines\02_build.cmd' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: many of these commands (e.g. dotnet) are platform independent, consider getting rid of the cmd file and make it self-contained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have GREATLY preferred this approach.
I went to office hours to ask this exact question. OneBranch does not permit in-line scripts as a rule!
In all of our github builds, i'm doing everything in-line:
run: dotnet build ./BASE/Microsoft.ApplicationInsights.sln --configuration Release --no-restore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some suggestions.
#2475.
This PR introduces the new pipelines for our new signed builds.
I need this on the
main
branch to test some of the compliance settings.Please review screenshots below for a description of the pipeline output.
A follow up PR will:
Changes
FYI: pipelines cannot have inline scripts and must use external files.
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines run
will queue all builds/AzurePipelines run <pipeline-name>
will queue a specific build