Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ETW message #2740

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix bug in ETW message #2740

merged 1 commit into from
Jan 31, 2023

Conversation

xiang17
Copy link
Member

@xiang17 xiang17 commented Jan 31, 2023

Fix Issue # .

Changes

Fix bug in ETW message. The second {0} seems like a bug. When troubleshooting an issue from this exception, it'd be helpful to have the information from the exception.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

@xiang17 xiang17 merged commit 943d54f into main Jan 31, 2023
@xiang17 xiang17 deleted the xiang17/fixETWMessage branch January 31, 2023 04:46
@@ -135,7 +135,7 @@ public void UnobservedTaskExceptionThrewUnhandledException(string exception, str
this.WriteEvent(13, exception, this.applicationNameProvider.Name);
}

[Event(14, Message = "Unknown error occured in {0}. Exception: {0}", Level = EventLevel.Error)]
[Event(14, Message = "Unknown error occured in {0}. Exception: {1}", Level = EventLevel.Error)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: occured -> occurred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants